[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] virsh: update virsh desc help docs



Dňa 8.2.2012 7:12, ajia redhat com  wrote / napísal(a):
From: Alex Jia<ajia redhat com>

The function cmdDesc says 'current is ignored', so should remove related
part from help docs.

Signed-off-by: Alex Jia<ajia redhat com>
---
  tools/virsh.c |    1 -
  1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/tools/virsh.c b/tools/virsh.c
index c107d8c..e60ef5a 100644
--- a/tools/virsh.c
+++ b/tools/virsh.c
@@ -1038,7 +1038,6 @@ static const vshCmdOptDef opts_desc[] = {
      {"domain", VSH_OT_DATA, VSH_OFLAG_REQ, N_("domain name, id or uuid")},
      {"live", VSH_OT_BOOL, 0, N_("modify/get running state")},
      {"config", VSH_OT_BOOL, 0, N_("modify/get persistent configuration")},
-    {"current", VSH_OT_BOOL, 0, N_("modify/get current state configuration")},
      {"title", VSH_OT_BOOL, 0, N_("modify the title instead of description")},
      {"edit", VSH_OT_BOOL, 0, N_("open an editor to modify the description")},
      {"new-desc", VSH_OT_ARGV, 0, N_("message")},

NACK,

The current semantics of virsh commands requires that --current can only be used exclusively with --live and --config. I forgot that in the haste of trying to get the API in before the freeze. I will post a patch fixing this and the doc later today. Thanks for pointing out.

Peter


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]