[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH libvirt] domain: add implicit USB controller



On 02/08/2012 02:26 AM, Osier Yang wrote:
> On 2012幎02月08日 08:48, Marc-André Lureau wrote:
>> Some tools, such as virt-manager, prefers having the default USB
>> controller explicit in the XML document. This patch makes sure there
>> is one. With this patch, it is now possible to switch from USB1 to
>> USB2 from the release 0.9.1 of virt-manager.
>>
>> Fix tests to pass with this change.

Great! Thanks for taking care of this.

<snip>

>> diff --git a/tests/define-dev-segfault b/tests/define-dev-segfault
>> index 3feff46..0a0532b 100755
>> --- a/tests/define-dev-segfault
>> +++ b/tests/define-dev-segfault
>> @@ -36,6 +36,7 @@ cat<<\EOF>  D.xml || fail=1
>>     <on_crash>destroy</on_crash>
>>     <devices>
>>       <emulator>/usr/bin/qemu-kvm</emulator>
>> +<controller type='usb' index='0'/>
>>       <serial type='pty'>
>>         <target port='0'/>
>>       </serial>

But the spacing here is weird... is that my mail client or the actual patch?
That <controller> should be indented. Other tests are similarly changed.

Thanks,
Cole


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]