[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v3] Support for cpu64-rhel* qemu cpu models



On 01/30/2012 09:25 AM, Martin Kletzander wrote:
> In qemu there are 2 cpu models (cpu64-rhel5 and cpu64-rhel6) not
> supported by libvirt. This patch adds the support with the flags
> specifications from /usr/share/qemu-kvm/cpu-model/cpu-x86_64.conf
> ---
> v3:
>  - fixed sse3 naming (it's 'pni' in the features)
> 
> v2:
>  - removed duplicated entries
> 
>  src/cpu/cpu_map.xml |   66 +++++++++++++++++++++++++++++++++++++++++++++++++++
>  1 files changed, 66 insertions(+), 0 deletions(-)

I'm assuming that you tested this (I did not spend the time meticulously
cross-checking qemu with this list).  Upstream qemu does not provide
these machine names; they are RHEL-specific.

Is it going to be an issue where we use libvirt on something like F16
where qemu does not have these machine names?  Or is it okay for libvirt
to have a larger list of machine names, to make out-of-box installation
of newer libvirt onto older RHEL/CentOS machines just work with those
new names?  I guess what I'm really asking is:

Should this be a RHEL-specific patch for just the RHEL version of
libvirt, rather than upstream?

If we can get that answered, the patch itself looks reasonable, but I'm
hesitant to ack without an answer.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]