[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 2/2] qemu: add virtio-scsi controller model



On Mon, Feb 13, 2012 at 08:51:17AM -0600, Anthony Liguori wrote:
> On 02/13/2012 08:35 AM, Paolo Bonzini wrote:
> >On 02/13/2012 03:15 PM, Anthony Liguori wrote:
> >>
> >>It should be noted that virtio-scsi has not been merged either in the
> >>Linux kernel or in QEMU yet.
> >>
> >>In particular, this patch assumes that we'll introduce a 'virtio-scsi'
> >>alias which I'm planning on objecting strongly too :-)
> >>
> >>This patch was taken into libvirt after posting the first non-RFC...
> >>
> >>Hopefully this hasn't hit a libvirt release yet.
> >
> >We just backed it out of 0.9.10. :)
> 
> Excellent :-)
> 
> For QMP commands, my recommendation is that libvirt wait for a
> command to appear in qapi-schema.json.  Note that we can add
> commands to qapi-schema.json without actually implementing them yet
> (by setting gen=False).
> 
> For new devices, we could come up with a similar mechanism if that's desirable.

Our general rule is that the QEMU patch must be committed, not merely
posted, before we apply the corresponding libvirt patch. For some reason
we slipped up & didn't follow our own rules with this particular patch.

Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]