[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Install API XML desc to a standard location



On 02/13/2012 09:49 AM, Daniel P. Berrange wrote:
> From: "Daniel P. Berrange" <berrange redhat com>
> 
> Language bindings may well want to use the libvirt-api.xml and
> libvirt-qemu-api.xml files to either auto-generate themselves,
> or sanity check the manually written bindings for completeness.
> Currently these XML files are not installed as standard, merely
> ending up as a %doc file in the RPM.
> 
> This changes them to be installed into $prefix/share/libvirt/apis/

Sounds like the right place.

> The *-refs.xml files are not installed, since those are only
> useful during generation of the online API doc files.
> 
> The pkg-config file is enhanced so that you cann query the install

s/cann/can/

> location of the API files. eg
> 
>   # pkg-config --variable=libvirt_qemu_api libvirt
>   /home/berrange/builder/i686-pc-mingw32/sys-root/mingw/share/libvirt/libvirt-qemu-api.xml
> 
> * docs/Makefile.am: Install libvirt-api.xml & libvirt-qemu-api.xml
> * libvirt.pc.in: Add vars for querying API install location
> * libvirt.spec.in, mingw32-libvirt.spec.in: Include API XML files
> ---
>  docs/Makefile.am        |    3 +++
>  libvirt.pc.in           |    3 +++
>  libvirt.spec.in         |    4 ++++
>  mingw32-libvirt.spec.in |    4 ++++
>  4 files changed, 14 insertions(+), 0 deletions(-)
> 

> diff --git a/docs/Makefile.am b/docs/Makefile.am
> index 5644fe2..2bef982 100644
> --- a/docs/Makefile.am
> +++ b/docs/Makefile.am
> @@ -85,6 +85,9 @@ qemu_xml = \
>    libvirt-qemu-api.xml \
>    libvirt-qemu-refs.xml
>  
> +apidir = $(pkgdatadir)/api
> +api_DATA = libvirt-api.xml libvirt-qemu-api.xml

It looks like this unconditionally installs libvirt-qemu-api.xml, even
when the package is built without the automake conditional WITH_QEMU.
But I couldn't pinpoint any reason why that wouldn't be okay, so I'm not
complaining.

ACK.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]