[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 1/2 v3] qemu: Set capabilities based on supported monitor commands



On 02/14/2012 09:45 AM, Michal Privoznik wrote:
> In the future (my next patch in fact) we may want to make
> decisions depending on qemu having a monitor command or not.

Love that wording :)

> Therefore, we want to set qemuCaps flag instead of querying
> on the monitor each time we are about to make that decision.
> ---
>  src/qemu/qemu_capabilities.c |    1 +
>  src/qemu/qemu_capabilities.h |    1 +
>  src/qemu/qemu_monitor.c      |   21 ++++++++++-----------
>  src/qemu/qemu_monitor.h      |    4 +++-
>  src/qemu/qemu_monitor_json.c |   15 +++++++++------
>  src/qemu/qemu_monitor_json.h |    5 ++++-
>  src/qemu/qemu_process.c      |    2 +-
>  7 files changed, 29 insertions(+), 20 deletions(-)

I agree with your v2 comments that adding a test for this is worth a
separate patch - still worth doing, but not enough to hold up committing
this as-is.

ACK.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]