[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] snapshot: fix snapshot deletion



On 02/15/2012 02:41 AM, Michal Privoznik wrote:
> On 14.02.2012 21:48, Eric Blake wrote:
>> Bug introduced in commit 35abced.  On an inactive domain,
>> $ virsh snapshot-create-as dom snap
>> $ virsh snapshot-create dom
>> $ virsh snapshot-create dom
>> $ virsh snapshot-delete --children dom snap
>> could crash libvirtd, due to a use-after-free that results
>> when the callback freed the current element in the iteration.
>>
>> * src/conf/domain_conf.c (virDomainSnapshotForEachChild)
>> (virDomainSnapshotActOnDescendant): Allow iteration to delete
>> current child.
>> ---
>>  src/conf/domain_conf.c |    5 +++--
>>  1 files changed, 3 insertions(+), 2 deletions(-)
>>
> 
> ACK

Thanks; pushed.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]