[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 03/10] conf: Set default scsi controller model when parsing



On 02/17/2012 05:58 PM, Osier Yang wrote:
>>
>> I don't think this is correct.  In fact, I think I misunderstood you
>> while we discussed this before by email.  So this patch is not necessary.
> 
> If you mean it's correct to check model in [PATCH 5/10] when formating
> the XML. This patch is neccessary, otherwise we have no way to known
> what model the driver sets by default, and thus no way to known how to
> format the XML.

Right, but we should always print "target".

> Even if we don't need to check the model when formating XML, I still
> think this patch is useful. Why we set default model silently, and
> don't show it up in XML? :-)

The default is "auto", no?  Which means spapr-vscsi on ppc64, and lsi
otherwise (unfortunately, but that's life).

Paolo


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]