[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v4 7/7] qemu: Add ability to abort existing console while creating new one



On 02/06/2012 06:50 AM, Peter Krempa wrote:
> This patch fixes console corruption, that happens if two concurrent
> sessions are opened for a single console on a domain. Result of this
> corruption was that each of the console streams recieved just a part

s/recieved/received/

> of the data written to the pipe so every console rendered unusable.
> 
> New helper function for safe console handling is used to establish the
> console stream connection. This function ensures that no other libvirt
> client is using the console (with the ability to disconnect consoles of
> libvirt clients) and that no UUCP style lockfile is placed on the PTY
> device.
> 
> * src/qemu/qemu_domain.h
>         - add data structure to domain's private data dealing with
>           console connections
> * src/qemu/qemu_domain.c:
>         - allocate/free domain's console data structure
> * src/qemu/qemu_driver.c
>         - use the new helper function for console handling
> ---
>  src/qemu/qemu_domain.c |    5 +++++
>  src/qemu/qemu_domain.h |    3 +++
>  src/qemu/qemu_driver.c |   21 ++++++++++++++++-----
>  3 files changed, 24 insertions(+), 5 deletions(-)

ACK.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]