[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCHv2] Error out when using SPICE TLS with spice_tls=0



On 02/24/2012 03:41 AM, Daniel P. Berrange wrote:
> On Fri, Feb 24, 2012 at 11:34:45AM +0100, Christophe Fergeau wrote:
>> It's possible to disable SPICE TLS in qemu.conf. When this happens,
>> libvirt ignores any SPICE TLS port or x509 directory that may have
>> been set when it builds the qemu command line to use. However, it's
>> not ignoring the secure channels that may have been set and adds
>> tls-channel arguments to qemu command line.
>> Current qemu versions don't report an error when this happens, and try to use
>> TLS for the specified channels.
>>

>>
>> This fixes bug #790436

Thanks for chasing this down.

> ACK, if we  s/XML_ERROR/CONFIG_UNSUPPORTED/  in the those two error
> messages

Changed and pushed.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]