[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 6/7] qemu: Build command line for the new address format



On 02/27/2012 12:59 PM, Osier Yang wrote:
> +                                _("target must be 0 for leagacy controller "
> +                                   "model 'lsilogic'"));

Remove (misspelled :)) "leagacy".

> +                goto error;
> +            }
> +
> +            virBufferAddLit(&opt, "scsi-disk");
> +            virBufferAsprintf(&opt, ",bus=scsi%d.%d,scsi-id=%d",
> +                              disk->info.addr.drive.controller,
> +                              disk->info.addr.drive.bus,
> +                              disk->info.addr.drive.unit);
> +        } else {
> +            if (!qemuCapsGet(qemuCaps, QEMU_CAPS_SCSI_DISK_CHANNEL)) {
> +                if (disk->info.addr.drive.target > 7) {
> +                    qemuReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s",
> +                                    _("This QEMU doesn't support target "
> +                                      "greater than 7"));
> +                    goto error;
> +                }
> +
> +                if ((disk->info.addr.drive.bus != disk->info.addr.drive.unit) &&
> +                    (disk->info.addr.drive.bus != 0)) {
> +                    qemuReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s",
> +                                    _("This QEMU only supports both bus and "
> +                                      "unit are equal to 0"));

Remove "are".

> +                    goto error;

Otherwise the series looks good.

Thanks!

Paolo


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]