[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] qemu: fix cleanup of bridge during failure of qemuDomainAttachNetDevice



On 02/27/2012 01:15 PM, Eric Blake wrote:
> On 02/25/2012 04:40 PM, Laine Stump wrote:
>> From: Laine Stump <laine redhat com>
>>
>> In qemuDomainAttachNetDevice, the guest's tap interface has only been
>> attached to the bridge if iface_connected is true. It's possible for
>> an error to occur prior to that happening, and previously we would
>> attempt to remove the tap interface from the bridge even if it hadn't
>> been attached.
>> ---
>>  src/qemu/qemu_hotplug.c |   11 ++++++-----
>>  1 files changed, 6 insertions(+), 5 deletions(-)
> ACK - looks like the patch was just the addition of {} followed by
> reindentation.
>

Correct - just moved the next stanza into the if. Pushed, thanks!


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]