[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [Resending] [PATCH 2/2] Allow x86 to fetch sysinfo from /proc/cpuinfo when dmidecode is absent.



On 02/17/2012 12:30 AM, Prerna wrote:
> The last patch was mangled by my mailer, resending.
> 
> From: Prerna Saxena <prerna linux vnet ibm com>
> Date: Thu, 16 Feb 2012 15:33:43 +0530
> Subject: [PATCH 2/2] Sysinfo : Allow x86 to fetch sysinfo from /proc/cpuinfo
>  in the event 'dmidecode' is absent in the system.
> 

> +        processor = &ret->processor[ret->nprocessor - 1];
> +        if ((eol) &&
> +            ((processor->processor_socket_destination =
> +                               strndup(cur, eol - cur)) == NULL))

This is over-parenthesized; I would write it:

if (eol &&
    (processor->processor_socket_destination =
     strndup(cur, eol - cur)) == NULL)

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]