[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [libvirt-glib] API to save and suspend



On Tue, Jan 3, 2012 at 5:35 PM, Marc-André Lureau
<marcandre lureau gmail com> wrote:
>
>
> On Tue, Jan 3, 2012 at 4:22 PM, Zeeshan Ali (Khattak) <zeeshanak gnome org>
> wrote:
>>
>> On Tue, Jan 3, 2012 at 5:08 PM, Zeeshan Ali (Khattak)
>> <zeeshanak gnome org> wrote:
>> > From: "Zeeshan Ali (Khattak)" <zeeshanak gnome org>
>> > +    res = g_simple_async_result_new(G_OBJECT(dom),
>> > +                                    callback,
>> > +                                    user_data,
>> > +                                    gvir_domain_saved_suspend);
>> > +    g_simple_async_result_set_op_res_gpointer (res, data, NULL);
>>
>>  The reason I'm not using destroy notify argument here is that I
>> can't: g_slice_free*() takes 2 arguments and thats not what
>> DestroyNotify expects. I could write a wrapper function but I don't
>> see the point.
>
>
> Oh, I see. Perhaps we don't need gslice then.

  Why? gslice is *the* glib way to allocate/free fixed-sized structures.

> fyi, none of the gio data
> structs used in this case are allocated with gslice  .

  Weird! Perhaps there is a reason for them to not use gslice there?

> Tbh, I think it's better having the small wrapper if we keep gslice.

  Why? I don't see any possible leaks here.

-- 
Regards,

Zeeshan Ali (Khattak)
FSF member#5124


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]