[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] command: Discard FD_SETSIZE limit for opened files



On 03.01.2012 17:33, Eric Blake wrote:
> On 01/03/2012 04:14 AM, Michal Privoznik wrote:
>> Currently, virCommand implementation uses FD_ macros from
>> sys/select.h. However, those cannot handle more opened files
>> than FD_SETSIZE. Therefore switch to generalized implementation
>> based on array of integers.
>> ---
>>  src/util/command.c |  108 ++++++++++++++++++++++++++++++++++++++++------------
>>  1 files changed, 83 insertions(+), 25 deletions(-)
> 
> NACK.  While I agree with the idea, I'd rather use virBitmap rather than
> open-coding an int array ourselves.
> 

Okay, but that would require of extending virBitmap as it is not capable
of growing dynamically. Anyway, that's not a big deal. Will post v2.

Michal


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]