[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Fix typos in libvirt messages



On 01/03/2012 12:35 PM, Yuri Chornoivan wrote:
> Hi!
> 
> Attached to this message you can find a patch from BZ 770954 [1]

Thanks.  ACK to your changes, and I've added you to AUTHORS (let me know
if I need to adjust anything for the preferred spelling of your name).

> 
> Thanks for reviewing it. Additionally, it can be useful to replace all
> "dettach" occurrences with "detach".

In user-visible messages (and perhaps comments), yes, but not in the
API.  Alas, backwards compatibility says that we are stuck with the typo
in the public entry point.

> +++ b/src/libvirt.c
> @@ -1025,7 +1025,7 @@ virConnectOpenFindURIAliasMatch(virConfValuePtr value, const char *alias, char *
>          safe  = strspn(entry->str, URI_ALIAS_CHARS);
>          if (safe < (offset - entry->str)) {
>              virLibConnError(VIR_ERR_CONF_SYNTAX,
> -                            _("Malformed 'uri_aliases' config entry '%s', aliases may only container 'a-Z, 0-9, _, -'"),
> +                            _("Malformed 'uri_aliases' config entry '%s', aliases may only contain 'a-Z, 0-9, _, -'"),
>                              entry->str);
>              return -1;
>          }
> @@ -10653,7 +10653,7 @@ virInterfaceFree(virInterfacePtr iface)
>   * This functions creates a restore point to which one can return
>   * later by calling virInterfaceChangeRollback(). This function should
>   * be called before any transaction with interface configuration.
> - * Once knowing, new configuration works, it can be commited via
> + * Once knowing, new configuration works, it can be committed via

Two tweaks that I squashed in:

s/This functions/This function/
s/Once knowing, new/Once it is known that a new/

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]