[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 2/4 V2] remote: mplement new API virDomainGetPcpusUsage for remote driver



The title for this should be 'implement', not 'mplement'.

> +/* Upper limit on list of physic cpu parameters. */

'physical'

> +const REMOTE_DOMAIN_PCPUS_USAGE_PARAMETERS_MAX = 16;

This seems a bit low.  Is this limiting us to returning information
about only 16 pCPUs?

Meta-comment: libvirt needs a generator ...

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
virt-df lists disk usage of guests without needing to install any
software inside the virtual machine.  Supports Linux and Windows.
http://et.redhat.com/~rjones/virt-df/


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]