[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 4/6] cpu: Update guest CPU in host-* mode



On 01/06/2012 08:04 AM, Jiri Denemark wrote:
> ---

A little light on the commit message, perhaps.

>  src/conf/cpu_conf.c                                |   75 +++++++++++++++-----
>  src/conf/cpu_conf.h                                |    8 ++
>  src/cpu/cpu_x86.c                                  |   30 +++++++-
>  src/libvirt_private.syms                           |    2 +
>  src/qemu/qemu_domain.c                             |   12 ++--
>  tests/cputest.c                                    |   18 ++++--
>  ...6-host+host+host-model,models,Penryn-result.xml |   19 +++++
>  .../cputestdata/x86-host+host-model-nofallback.xml |   19 +++++
>  tests/cputestdata/x86-host+host-model.xml          |   18 +++++
>  tests/cputestdata/x86-host+host-passthrough.xml    |   18 +++++
>  tests/cputestdata/x86-host-model-nofallback.xml    |    4 +
>  tests/cputestdata/x86-host-model.xml               |    1 +
>  tests/cputestdata/x86-host-passthrough.xml         |    1 +
>  13 files changed, 194 insertions(+), 31 deletions(-)
>  create mode 100644 tests/cputestdata/x86-host+host+host-model,models,Penryn-result.xml
>  create mode 100644 tests/cputestdata/x86-host+host-model-nofallback.xml
>  create mode 100644 tests/cputestdata/x86-host+host-model.xml
>  create mode 100644 tests/cputestdata/x86-host+host-passthrough.xml
>  create mode 100644 tests/cputestdata/x86-host-model-nofallback.xml
>  create mode 100644 tests/cputestdata/x86-host-model.xml
>  create mode 100644 tests/cputestdata/x86-host-passthrough.xml

But overall it looked sane, and I didn't spot anything obviously wrong.

ACK.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]