[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v2] Do not generate security_model when fs driver is anything but 'path'



On Tue, Jan 10, 2012 at 03:35:26PM +0530, Deepak C Shetty wrote:
> QEMU does not support security_model for anything but 'path' fs driver type.
> Currently in libvirt, when security_model ( accessmode attribute) is not
> specified it auto-generates it irrespective of the fs driver type, which
> can result in a qemu error for drivers other than path. This patch ensures
> that the qemu cmdline is correctly generated by taking into account the
> fs driver type.
> 
> Signed-off-by: Deepak C Shetty <deepakcs linux vnet ibm com>
> ---
> v2:
> - removed xml accessmode changes as suggested by dan.
> - every fs driver having a default accessmode always, retained.
> 
>  src/qemu/qemu_command.c |   23 +++++++++++++++++------
>  1 files changed, 17 insertions(+), 6 deletions(-)

ACK

Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]