[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v3] Add new attribute wrpolicy to <driver> element



On 01/11/2012 03:19 PM, Eric Blake wrote:
> On 01/10/2012 07:29 AM, Deepak C Shetty wrote:
>> This introduces new attribute wrpolicy with only supported
>> value as immediate. This will be an optional
>> attribute with no defaults. This helps specify whether
>> to skip the host page cache.
>>
>> When wrpolicy is specified, meaning when wrpolicy=immediate
>> a writeback is explicitly initiated for the dirty pages in
>> the host page cache as part of the guest file write operation.
>>
>> Usage:
>> <filesystem type='mount' accessmode='passthrough'>
>>   <driver type='path' wrpolicy='immediate'/>
>>   <source dir='/export/to/guest'/>
>>   <target dir='mount_tag'/>
>> </filesystem>
>>
>> Currently this only works with type='mount' for the QEMU/KVM driver.
>>

Also, I meant to add:

>> 
>>  docs/formatdomain.html.in     |   12 ++++++++++--
>>  docs/schemas/domaincommon.rng |    7 +++++++
>>  src/conf/domain_conf.c        |   27 ++++++++++++++++++++++++++-
>>  src/conf/domain_conf.h        |   10 ++++++++++
>>  src/qemu/qemu_capabilities.c  |    3 +++
>>  src/qemu/qemu_capabilities.h  |    5 +++--
>>  src/qemu/qemu_command.c       |   14 ++++++++++++++
>>  7 files changed, 73 insertions(+), 5 deletions(-)

Please add a new pair of test files to tests/qemuxml2argvdata (both .xml
and .args file) to validate the RNG, as well as listing that file name
in tests/qemuxml2argvtest.c to validate the qemu command line generation
(I find it easiest to start from an existing similar .xml file, and just
add in the new attribute).

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]