[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

[libvirt] [PATCH 0/4] add virsh domxml-formats

I previously proposed this here:
although it's been on my wish list a lot longer than that.

Questions: I had the new API take nformats as an int, and return the
number of populated slots; should I switch this to take *nformats as
a pointer (being both input and output) with a return value of 0, so
as to be more consistent with things like virDomainGetMemoryParameters?

I'm not very familiar with writing python bindings, at least not without
the benefit of copy-and-paste, and I didn't see a good example to copy
from.  Ultimately, I envision that the python API will be something like
virConnect.domainNativeFormats(self, flags), with a return being
a python list of strings (where the underlying code calls
virConnectDomainNativeFormats twice, once to determine the list
size, and once to determine the list contents), but I'm not sure how
to go about doing that (I don't know if generator.py can do it, or
if it needs an override, or what).  So I left the python bindings
undone, and would appreciate if someone else can step in and help.

Eric Blake (4):
  native: add virConnectNativeFormats API
  native: add virsh command domxml-formats
  native: implement rpc handling of new API
  native: add driver support

 daemon/remote.c              |   56 ++++++++++++++++++++++++++++++++++++
 include/libvirt/libvirt.h.in |    4 ++
 python/generator.py          |    3 ++
 src/driver.h                 |    6 ++++
 src/esx/esx_driver.c         |   20 ++++++++++++-
 src/libvirt.c                |   59 ++++++++++++++++++++++++++++++++++++++
 src/libvirt_public.syms      |    5 +++
 src/libxl/libxl_driver.c     |   22 +++++++++++++-
 src/qemu/qemu_driver.c       |   17 +++++++++++
 src/remote/remote_driver.c   |   64 +++++++++++++++++++++++++++++++++++++++++-
 src/remote/remote_protocol.x |   17 ++++++++++-
 src/remote_protocol-structs  |   12 ++++++++
 src/xen/xen_driver.c         |   27 +++++++++++++++++-
 tools/virsh.c                |   48 +++++++++++++++++++++++++++++++
 tools/virsh.pod              |   11 ++++++-
 15 files changed, 362 insertions(+), 9 deletions(-)


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]