[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 3/4] tests: Add qemuxml2argv tests for PPC64 pseries machine



On 01/12/2012 08:39 PM, Michael Ellerman wrote:
> Add four tests of the XML -> argv handling for the PPC64 pseries machine.
> 
> The first is just a basic test of a bare bones machine.
> 
> The three others test various aspects of the spapr-vio address handling.
> 
> It seems that currently we can't include network devices, doing so leads
> to a segfault because the network driverState is not initialised. Working
> around that leads us to the problem that the 'default' network doesn't
> exist. So for now just leave network devices out.

Hmm - it'd be nice to figure out a way to work around that, but any
testing is better than none, so what you have is worth checking in as a
strict improvement.

> 
> Signed-off-by: Michael Ellerman <michael ellerman id au>
> ---
>  .../qemuxml2argv-pseries-basic.args                |    1 +
>  .../qemuxml2argv-pseries-basic.xml                 |   17 ++++++++
>  .../qemuxml2argv-pseries-vio-address-clash.xml     |   42 ++++++++++++++++++++
>  .../qemuxml2argv-pseries-vio-user-assigned.args    |    1 +
>  .../qemuxml2argv-pseries-vio-user-assigned.xml     |   42 ++++++++++++++++++++
>  .../qemuxml2argvdata/qemuxml2argv-pseries-vio.args |    1 +
>  .../qemuxml2argvdata/qemuxml2argv-pseries-vio.xml  |   42 ++++++++++++++++++++
>  tests/qemuxml2argvtest.c                           |    9 ++++
>  8 files changed, 155 insertions(+), 0 deletions(-)

ACK and pushed.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]