[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 4/4] conf: Remove do-nothing validation functions



On 01/12/2012 08:39 PM, Michael Ellerman wrote:
> There are three address validation routines that do nothing:
>   virDomainDeviceDriveAddressIsValid()
>   virDomainDeviceUSBAddressIsValid()
>   virDomainDeviceVirtioSerialAddressIsValid()
> 
> Remove them, and replace their call sites with "1" which is what they
> currently return. In some cases this means we can remove an entire
> if block.

They've been no-ops for a LOOONG time, and I don't see us ever needing
to revive them (and even if we did, we have git log to tell us what they
were).  Thanks for doing this housecleaning.

> 
> Signed-off-by: Michael Ellerman <michael ellerman id au>
> ---
>  src/conf/domain_conf.c |   36 ++----------------------------------
>  src/conf/domain_conf.h |    3 ---
>  2 files changed, 2 insertions(+), 37 deletions(-)

ACK and pushed.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]