[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v2 5/6] Taint domains configured with cpu mode=host-passthrough



On 01/12/2012 04:02 AM, Jiri Denemark wrote:
> There are several reasons for doing this:
> 
> - the CPU specification is out of libvirt's control so we cannot
>   guarantee stable guest ABI
> - not every feature of a CPU may actually work as expected when
>   advertised directly to a guest
> - migration between two machines with exactly the same CPU may work but
>   no guarantees can be made
> - this mode is not supported and it's use is at one's own risk

s/it's/its/

> ---
> Notes:
>     Version 2:
>     - more verbose commit message

Per your rebuttal on v1, I agree that we can defer documentation of
tainting to a later patch (it's a pre-existing problem, that your patch
didn't make any worse, although fixing it will now involve more text).
Therefore, I'm okay giving ACK, but I'm hoping that we have taint
documentation by 0.9.10 (and I may be able to step in and help provide
some).

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]