[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] qemu: Don't break domain with 0:0:2.0 assigned to anything but VGA



On 01/17/2012 08:47 AM, Jiri Denemark wrote:
> In the past we didn't reserve 0:0:2.0 PCI address if there was no video
> device assigned to a domain, which made it impossible to add a video
> device later on. So we fixed it (commit v0.9.0-37-g7b2cac1) by always
> reserving that address. However, that breaks existing domains without
> video devices that already have another device assigned to the
> problematic address.
> 
> This patch reserves address 0:0:2.0 only in case it was not explicitly
> assigned to another device, which means libvirt will try to keep this
> address free and will not automatically assign it new devices. But
> existing domains for which older libvirt already assigned the address to
> a non-video device will keep working as they used to work before 0.9.1.
> Moreover, users who want to create a domain without a video device and
> use its address for another device may do so by explicitly configuring
> the PCI address in domain XML.
> ---
>  src/qemu/qemu_command.c |   21 +++++++++++++++------
>  1 files changed, 15 insertions(+), 6 deletions(-)

ACK.

Nasty that we had a regression in ABI for that long.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]