[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH RFCv2 0/5] LibSSH2 transport for libvirt



On Wed, Jan 04, 2012 at 12:47:36AM +0100, Peter Krempa wrote:
> This patchset proposes to use libssh2 as ssh transport option in libvirt
> instead of the usual "spawn the client and connect pipes" approach.
> 
> For this to work, you'll need at least libssh2 v 1.3.0.
> 
> This is the second iteration of this functionality. I have completed nearly
> all of the functionality and tested most of the common situations.
> 
> If you'd like to try this out, I've prepared for you a branch in my git repo:
> 
> git checkout -B libssh_transport 66ca7ce573a69858c5af60645984bb1f2f90b1e7
> git pull git://aeon.pipo.sk/libvirt.git libssh_transport
> 
> (It should be up most of the time)
> 
> To test the connection use URI's in the following format:
> 
> qemu+libssh://USER HOST:PORT/system?known_hosts=PATH_TO_KNOWN_HOSTS_FILE&keyfile=PATH_TO_PRIVATE_KEY
> 
> The parameters may be omitted and then they take a default value (root localhost:22).
> 
> SSH Agent authentication is supported automaticaly. For public key to work
> you need to specify the path to the key.
> 
> For host key verification to work, you'll need to specify the path
> to a known_hosts file. (It may be empty and even don't exist).
> 
> I'd appreciate your feedback. Thanks for your comments and time.

I've not had a chance to send detailed review feedback, but I wanted
to say that I like the way you have integrated libssh into the
virNetSocket code. So from an architectural / design point of view,
these patches get my vote. I'll try and do a code review soon...

Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]