[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v2 5/6] util: Add helpers for safe domain console operations



On Wed, Jan 18, 2012 at 02:47:13PM +0100, Peter Krempa wrote:
> On 01/18/2012 12:38 AM, Eric Blake wrote:
> >On 12/07/2011 11:08 AM, Peter Krempa wrote:
> >>This patch adds a set of functions used in creating console streams for
> >>domains using PTYs and ensures mutualy exculsive access to the PTYs.
> >
> >Picking up on my (stalled) review...
> >
> >>+++ b/src/Makefile.am
> >>@@ -101,6 +101,9 @@ UTIL_SOURCES =							\
> >>  		util/virsocketaddr.h util/virsocketaddr.c \
> >>  		util/virtime.h util/virtime.c
> >>
> >>+SAFE_CONSOLE_SOURCES = \
> >>+		util/domain_safe_console.c util/domain_safe_console.h
> >
> >Unless you are planning on including these sources into an independent
> >library, I see no need to make a new variable.  Just add these files
> >into the right place within UTIL_SOURCES.
> 
> This is a little bit tricky. My first approach was to add it to
> UTIL_SOURCES, but then I got errors about missing references (This
> code needs references to streams and other stuff from
> libvirt.[c|h].) while building the LXC helper tool. This works it
> around, as the lxc app does not get built with these sources, and
> the util lib does.
> 
> Do you have any suggestions, how to work around getting errors from
> the lxc app? I'd rather use the UTIL_SOURCES var. if possible.

This is probably pushing the definition of what should go in util.

I'd put it in src/conf, where we put other domain helper stuff
like the events code.


Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]