[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 2/5 V3] remote: mplement new API virDomainGetPcpusUsage for remote driver



There is a typo in the commit message: mplement -> implement

On Wed, Jan 18, 2012 at 03:12:09PM +0800, Lai Jiangshan wrote:
> +/* Upper limit on list of physical cpu parameters. */
> +const REMOTE_DOMAIN_PCPUS_USAGE_PARAMETERS_MAX = 32;

This number is bigger than the previous version, but is there some
reason not to make it very big (eg. 4096)?  It's not completely
unknown to have machines with more than 32 physical CPUs.
8*4096 bytes is fine for the libvirt protocol.

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
New in Fedora 11: Fedora Windows cross-compiler. Compile Windows
programs, test, and build Windows installers. Over 70 libraries supprt'd
http://fedoraproject.org/wiki/MinGW http://www.annexia.org/fedora_mingw


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]