[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [libvirt-glib 3/4] Split gvir_config_object_attach



On Wed, Jan 18, 2012 at 04:50:43PM +0100, Christophe Fergeau wrote:
> Most of the time we want gvir_config_object_attach to replace
> existing nodes, but sometimes (for <devices> subnodes) we want
> it to append the new node and to keep the existing nodes with
> the same name. This commit solves this by adding 2 distinct helpers,
> _attach_add and _attach_replace.
> This should fix some unexpected behaviour of various _set_ functions
> which were appending new nodes instead of replacing the existing one.
> ---
>  libvirt-gconfig/libvirt-gconfig-domain.c           |   20 +++++++++++---------
>  libvirt-gconfig/libvirt-gconfig-object-private.h   |    6 ++++--
>  libvirt-gconfig/libvirt-gconfig-object.c           |   20 ++++++++++++++++++--
>  .../libvirt-gconfig-storage-pool-target.c          |    4 ++--
>  libvirt-gconfig/libvirt-gconfig-storage-pool.c     |    8 ++++----
>  .../libvirt-gconfig-storage-vol-target.c           |    4 ++--
>  libvirt-gconfig/libvirt-gconfig-storage-vol.c      |    8 ++++----
>  libvirt-gconfig/libvirt-gconfig.sym                |    1 -
>  8 files changed, 45 insertions(+), 26 deletions(-)

ACK

Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]