[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 2/4] conf: add kvmclock timer



On Mon, Jan 23, 2012 at 14:11:09 +0100, Paolo Bonzini wrote:
> Add kvmclock timer to documentation, schema and parsers.  Keep the
> platform timer first since it is kind of special, and alphabetize
> the others when possible (i.e. when it does not change the ABI).

Any chance the "clock" part in "kvmclock" is redundant since we're setting a
timer? I'm not suggesting either way, I'm just asking whether it would make
sense to name the new timer "kvm" instead of "kvmclock".

> Signed-off-by: Paolo Bonzini <pbonzini redhat com>
> ---
>  docs/formatdomain.html.in     |    4 ++--
>  docs/schemas/domaincommon.rng |    3 ++-
>  src/conf/domain_conf.c        |    3 ++-
>  src/conf/domain_conf.h        |    1 +
>  4 files changed, 7 insertions(+), 4 deletions(-)

ACK regardless on the answer to the question above.

Jirka


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]