[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 3/7] Revert changes to sec label parsing



On 01/11/2012 09:33 AM, Daniel P. Berrange wrote:
> From: "Daniel P. Berrange" <berrange redhat com>
> 
> Revert parsing changes:
> 
>   commit 302fe95ffa1bc5f1c61c0beb31a1adfbc38c668e
>   Author: Eric Blake <eblake redhat com>
>   Date:   Wed Jan 4 16:01:24 2012 -0700
> 
>     seclabel: fix regression in libvirtd restart
> 
>   commit b43432931aef92325920953ff92beabfbe5224c8
>   Author: Eric Blake <eblake redhat com>
>   Date:   Thu Dec 22 17:47:50 2011 -0700
> 
>     seclabel: allow a seclabel override on a disk src
> 
> These two commits changed the sec label parsing code so that
> the same code dealt with both the VM level sec label, and the
> per device label. Unfortunately, as we add more options to the
> VM level sec label, the logic required to use the same parsing
> code for the per device label becomes unintelligable.

s/unintelligable/unintelligible/

> 
> * src/conf/domain_conf.c: Remove support for parsing per
>   device sec labels
> ---
>  src/conf/domain_conf.c |  190 ++++++++++++-----------------------------------
>  1 files changed, 49 insertions(+), 141 deletions(-)

With this patch applied, we get a testsuite failure.  But I guess that
is to be expected - we reverted functionality and won't be restoring it
until 4/7.  I can live with the 'git bisect' weakness.

ACK, assuming I like 4/7.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]