[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 3/4] qemu: parse and create -cpu ..., -kvmclock



On Mon, Jan 23, 2012 at 14:11:10 +0100, Paolo Bonzini wrote:
> Creating part of the -cpu command-line from something other than the
> <cpu> XML element introduces some ugliness.

Well, that's what we get for creating virtual CPUID features :-)

> ---
>  src/qemu/qemu_command.c                            |   72 ++++++++++++++++++--
>  tests/qemuargv2xmltest.c                           |    4 +
>  .../qemuxml2argv-cpu-host-kvmclock.args            |    4 +
>  .../qemuxml2argv-cpu-host-kvmclock.xml             |   23 ++++++
>  .../qemuxml2argv-cpu-kvmclock.args                 |    4 +
>  .../qemuxml2argvdata/qemuxml2argv-cpu-kvmclock.xml |   24 +++++++
>  tests/qemuxml2argvdata/qemuxml2argv-kvmclock.args  |    4 +
>  tests/qemuxml2argvdata/qemuxml2argv-kvmclock.xml   |   21 ++++++
>  tests/qemuxml2argvtest.c                           |    3 +
>  tests/qemuxml2xmltest.c                            |    3 +
>  10 files changed, 157 insertions(+), 5 deletions(-)
>  create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-cpu-host-kvmclock.args
>  create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-cpu-host-kvmclock.xml
>  create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-cpu-kvmclock.args
>  create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-cpu-kvmclock.xml
>  create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-kvmclock.args
>  create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-kvmclock.xml

Thanks for creating tests right away :-)

ACK

Jirka


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]