[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 1/4] qemu: get arch name from <cpu> element



On Mon, Jan 23, 2012 at 17:21:01 +0100, Paolo Bonzini wrote:
> On 01/23/2012 04:52 PM, Jiri Denemark wrote:
> > I think we could just set cpu->model even if the model used in qemu command
> > line was {qemu,kvm}{32,64}. That would probably mean we need to add some of
> > the models in cpu_map.xml, though.
> 
> Actually I was doing that on purpose, not just for laziness. :)
> 
> The idea is that, if you were using -cpu just to set "-cpu 
> {qemu,kvm}{32,64},-kvmclock", you will not get an irrelevant 
> <cpu><model>qemu32</model></cpu> in domxml-from-native output.

Yeah, I understand why you did so, however, you just discard {qemu,kvm}{32,64}
models even if there were more flags than just +-kvmclock specified, don't
you? Anyway, <cpu><model>qemu32</model></cpu> doesn't seem irrelevant to me,
it just describes the guest visible hardware.

Jirka


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]