[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH][RFC] adding a title to the domain description informations



On Tue, Jan 24, 2012 at 08:06:31AM -0700, Eric Blake wrote:
> On 01/24/2012 07:18 AM, Daniel Veillard wrote:
> >  The idea is that currently we have only the domain name usable as
> > a description for the domain. It is not really a good human readable
> > identifier, as the kind of string allowed is limited (no space for
> > example). The idea would then be to extend the existing <description>
> > field in the domain XML to keep 40 or less character string to describe
> > a domain and provide that information later for example in an extended
> > virsh list command or for other interfaces.
> >   While the idea is simple, see attached patch for this, it becomes more
> > complex when one tries to make accessors to set/get that title for a
> > domain, since it's mutable and possibly could be coming from the
> > hypervisor itself (is there anything like this in VMWare or VirtualBox?)
> > it should to be implemented down at the driver level. Is that worth the
> > effort ? If we go that route should we do this for other objects
> > (network, storage, etc ...) too in the end ?
> > 
> > here is a basic patch for just the XML side to give an idea, but
> > adding APIs is far more work.
> > 
> >   Opinions ?
> 
> Looks like this is more or less identical to Peter's proposal to add a
> <title> element:
> https://www.redhat.com/archives/libvir-list/2012-January/msg00710.html
> 
> so I'm all for the idea (not sure whether your patch or Peter's is
> better for the idea).
> 
> As far as I know, the title is _not_ coming from the hypervisor itself,
> nor is it guest-visible; it is merely metadata from the host's perspective.

  Okay, let's go with Peter's then, the only difference is that he is
  using an element to store the title instead of an attribute on 
  the description element. That may be simpler in the end, so I'm fine
  dropping my patch :-)

Daniel

-- 
Daniel Veillard      | libxml Gnome XML XSLT toolkit  http://xmlsoft.org/
daniel veillard com  | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library  http://libvirt.org/


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]