[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v2 3/3] nwfilter: Rebuild filters only if new filter is different than current



On 01/23/2012 04:59 PM, Eric Blake wrote:
On 01/18/2012 09:20 AM, Stefan Berger wrote:
Compare two filter definitions for equality and only rebuild/instantiate
the new filter if the two filters are found to be different. This improves
performance during an update of a filter with no obvious change or the reloading
of filters during a 'kill -SIGHUP'

Unforuntately this more involved than a mere memcmp() on the structures.

2012

Big, but looks like a rather mechanical conversion of the various
protocols into a highly repetitive algorithm for comparisons.  I didn't
notice any major problems, so:

ACK with nits fixed.

After some consideration I decided not to push this patch but go a different route: have the new XML parsed, convert new and old internal representation of the filters to XML and compare those. This will be much less code.

   Stefan


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]