[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] lxc: export container=lxc-libvirt for systemd



On 01/25/2012 08:18 AM, Serge Hallyn wrote:
> Quoting Daniel P. Berrange (berrange redhat com):
>> On Tue, Jan 24, 2012 at 11:53:38AM -0700, Eric Blake wrote:
>>> Systemd detects containers based on whether they have
>>> an environment variable starting with 'container=lxc';
>>> using a longer name fits the expectations, while also
>>> allowing detection of who created the container.
>>>
>>> Requested by Lennart Poettering, in response to
>>> https://bugs.freedesktop.org/show_bug.cgi?id=45175
>>>

>> ACK, I had actually offered to do this before, but at the time
>> it was though having LIBVIRT_LXC_UUID was fine.
> 
> And it still is...  right?  container= is just deemed prettier?

According to the systemd bug above, yes.  Also, from my IRC conversation
with Lennart, I came away with the idea that other containers are also
setting $container, so having ALL containers set the same environment
variable (and realizing that other containers obviously won't be using
LIBVIRT_LXC_*) makes it easier for systemd to recognize all containers
from just a single variable name, rather than having to hand-maintain a
growing list as new containers are created.

At any rate, I've pushed the patch now.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]