[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] storage: Fix any VolLookupByPath if we have an empty logical pool



On 01/25/2012 11:15 AM, Cole Robinson wrote:
> On F16 at least, empty volume groups don't have a directory under /dev.
> The directory only appears once a logical volume is created.
> 
> This tickles some behavior in BackendStablePath which ends with
> libvirt sleeping for 5 seconds while waiting for the directory to appear.
> This causes all sorts of problems for the virStorageVolLookupByPath API
> which virtinst uses, even if trying to resolve a path that is independent
> of the logical pool.
> 
> In reality we don't even need to do that checking since logical pools
> always have a stable target path. Short circuit the polling in that
> case.
> 
> Fixes bug 782261
> ---
>  src/storage/storage_backend.c |    4 ++++
>  1 files changed, 4 insertions(+), 0 deletions(-)

ACK.  Isn't it funny how small a patch can be in proportion to the time
it took you to analyze why that one if statement is needed?

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]