[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 3/6] conf: move rombar and bootIndex into virDomainDeviceInfo



On 01/25/2012 09:58 AM, Laine Stump wrote:
> To help consolidate the commonality between virDomainHostdevDef and
> virDomainInterface into as few members as possible (and because I
> think it makes sense), this patch moves the rombar and bootIndex
> members into the "info" member that is common to both (and to all the
> other structs that use them).
> 
> It's a bit problematic that this gives rombar and bootIndex to many
> device types that don't use them, but this is already the case for the
> master and mastertype members of virDomainDeviceInfo, and is properly
> commented as such in the definition.
> 
> Note that this opens the door to supporting rombar for other devices
> that are attached to the guest PCI bus - virtio-blk-pci,
> virtio-net-pci, various other network adapters - which which have that
> capability in qemu, but previously had no support in libvirt.

Looks like a reasonable move; the code itself is fine once we accept the
need for the refactoring.  ACK.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]