[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 5/6] qemu: (and conf) support rombar for network devices



On 01/25/2012 09:58 AM, Laine Stump wrote:
> When support for the rombar option was added, it was only added for
> PCI passthrough devices, configured with <hostdev>. The same option is
> available for any network device that is attached to the guest's PCI
> bus. This patch allows setting rombar for any PCI network device type.
> 
> After adding cases to test this to qemuxml2argv-hostdev-pci-rombar.*,
> I decided to rename those files (to qemuxml2argv-pci-rom.*) to more
> accurately reflect the additional tests, and also noticed that up to
> now we've only been performing a domainschematest for that case, so I
> added the "pci-rom" test to both qemuxml2argv and qemuxml2xml (and in
> the process found some bugs whose fixes I squashed into previous
> commits of this series).
> ---
>  docs/formatdomain.html.in                          |   27 ++++++++++
>  docs/schemas/domaincommon.rng                      |   25 ++++++---
>  src/conf/domain_conf.c                             |    6 ++-
>  src/qemu/qemu_command.c                            |   54 +++++++++++++-------
>  .../qemuxml2argv-hostdev-pci-rombar.args           |    5 --
>  tests/qemuxml2argvdata/qemuxml2argv-pci-rom.args   |   12 ++++
>  ...dev-pci-rombar.xml => qemuxml2argv-pci-rom.xml} |   18 +++++++
>  tests/qemuxml2argvtest.c                           |    3 +
>  tests/qemuxml2xmltest.c                            |    1 +

docs, rng, and tests all in one go!  I'm impressed :)

I didn't see anything fishy in here, so ACK.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]