[libvirt] [libvirt-glib] Prefer 'for' over 'while'
Christophe Fergeau
cfergeau at redhat.com
Thu Jan 26 09:19:56 UTC 2012
On Thu, Jan 26, 2012 at 08:18:38AM +0100, Philipp Hahn wrote:
> Your changed version only has the same behaviour, if the user-passed-in
> function iter_func() never changes it->next, which you can't guarentee here.
> You need to keep the "next" copy.
Yes, the for loop was changed to a while loop recently exactly for that
purpose:
commit e1c15dac18fd5fc3d7c2cbfebb0402c05cc3cee3
http://libvirt.org/git/?p=libvirt-glib.git;a=commit;h=e1c15dac18fd5fc3d7c2cbfebb0402c05cc3cee3
Refactor gvir_config_object_delete_child
By changing gvir_config_xml_foreach_child to make it robust against
current node deletion in the "foreach" callback, we can use
gvir_config_object_foreach_child to implement
gvir_config_object_delete_child
Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20120126/8c95887b/attachment-0001.sig>
More information about the libvir-list
mailing list