[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

[libvirt] [PATCH RFC 0/4] Allow hibernation on guests

As we've added guest agent recently, the whole world
of new functionality has opened. As this patch set,
which allows domains to enter S4 state.

What is needed for this?
Patched qemu. As this is not in qemu git, but patches
are await to be pushed in very short future. They can
be found here:


Despite that, if anybody is willing to give me review
if I am going the right way, I'd appreciate it.

One thing, that you'll probably notice is this
'set-support-level' command. Basically, it tells GA what qemu version
is it running on. Ideally, this should be done as soon as
GA starts up. However, that cannot be determined from outside
world as GA doesn't emit any events yet.
Ideally^2 this command should be left out as it should be qemu
who tells its own agent this kind of information.
Anyway, I was going to call this command in qemuProcess{Startup,
Reconnect,Attach}, but it won't work. We need to un-pause guest CPUs
so guest can boot and start GA, but that implies returning from qemuProcess*.

So I am setting this just before 'guest-suspend' command, as
there is one more thing about GA. It is unable to remember anything
upon its restart (GA process). Which has BTW show flaw
in our current code with FS freeze & thaw. If we freeze guest
FS, and somebody restart GA, the simple FS Thaw will not succeed as
GA thinks FS are not frozen. But that's a different cup of tea.

Because of what written above, we need to call set-level
on every suspend.

Michal Privoznik (4):
  qemu-agent: Allow setting supported level
  qemu-agent: Create suspend function
  Create new virDrvDomainSuspendFlags API
  Wire up qemu agent for suspend

 include/libvirt/libvirt.h.in |    8 +++
 src/driver.h                 |    4 ++
 src/libvirt.c                |   55 ++++++++++++++++++++++
 src/libvirt_public.syms      |    1 +
 src/qemu/qemu_agent.c        |  105 ++++++++++++++++++++++++++++++++++++++++++
 src/qemu/qemu_agent.h        |   13 +++++
 src/qemu/qemu_driver.c       |   57 +++++++++++++++++++---
 src/qemu/qemu_process.c      |   45 +++++++++++++++++-
 src/remote/remote_driver.c   |    1 +
 src/remote/remote_protocol.x |    9 +++-
 src/remote_protocol-structs  |    5 ++
 tools/virsh.c                |   30 ++++++++++--
 12 files changed, 317 insertions(+), 16 deletions(-)


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]