[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH RFC 3/4] Create new virDrvDomainSuspendFlags API



On 26.01.2012 15:17, Eric Blake wrote:
> On 01/26/2012 07:06 AM, Michal Privoznik wrote:
>> define these flags:
>>
>>    VIR_DOMAIN_SUSPEND_SLEEP     = 0,        /* Suspend to RAM */
>>    VIR_DOMAIN_SUSPEND_HIBERNATE = (1 << 0), /* Suspend to disk */
> 
> Not quite right.  Our policy when fixing old APIs that forgot a flags
> argument is that the new API with flags 0 must be identical to the old
> API.  Which means you need:
> 
> VIR_DOMAIN_SUSPEND_PAUSE = 0, /* pause CPUs */
> VIR_DOMAIN_SUSPEND_SLEEP = 1<<0, /* Suspend to RAM, power stays on */

Honestly, in case of virtual machines I can't see the difference between
these two. But okay, I'll rewrite it.

Michal


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]