[libvirt] [libvirt-glib] Don't loop forever on blank nodes
Daniel P. Berrange
berrange at redhat.com
Thu Jan 26 17:09:04 UTC 2012
On Thu, Jan 26, 2012 at 07:02:41PM +0200, Zeeshan Ali (Khattak) wrote:
> From: "Zeeshan Ali (Khattak)" <zeeshanak at gnome.org>
>
> ---
> libvirt-gconfig/libvirt-gconfig-helpers.c | 11 ++++++-----
> 1 files changed, 6 insertions(+), 5 deletions(-)
>
> diff --git a/libvirt-gconfig/libvirt-gconfig-helpers.c b/libvirt-gconfig/libvirt-gconfig-helpers.c
> index c406a49..fecf3eb 100644
> --- a/libvirt-gconfig/libvirt-gconfig-helpers.c
> +++ b/libvirt-gconfig/libvirt-gconfig-helpers.c
> @@ -174,11 +174,12 @@ void gvir_config_xml_foreach_child(xmlNodePtr node,
> gboolean cont;
> xmlNodePtr next = it->next;
>
> - if (xmlIsBlankNode(it))
> - continue;
> - cont = iter_func(it, opaque);
> - if (!cont)
> - break;
> + if (!xmlIsBlankNode(it)) {
> + cont = iter_func(it, opaque);
> + if (!cont)
> + break;
> + }
> +
> it = next;
> }
> }
ACK
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
More information about the libvir-list
mailing list