[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Update VIRT_CONTROL audit record with pid.



On 01/26/2012 10:16 AM, Marcelo Cerri wrote:
> Added a new field "vm-pid" to the VIRT_CONTROL audit record. This information
> is useful to correlated another audit events to the events generated by
> libvirt.
> ---
>  src/conf/domain_audit.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/src/conf/domain_audit.c b/src/conf/domain_audit.c
> index 16937dc..eb85ec7 100644
> --- a/src/conf/domain_audit.c
> +++ b/src/conf/domain_audit.c
> @@ -562,8 +562,8 @@ virDomainAuditLifecycle(virDomainObjPtr vm, const char *op,
>      }
>  
>      VIR_AUDIT(VIR_AUDIT_RECORD_MACHINE_CONTROL, success,
> -              "virt=%s op=%s reason=%s %s uuid=%s",
> -              virt, op, reason, vmname, uuidstr);
> +              "virt=%s op=%s reason=%s %s uuid=%s vm-pid=%d",
> +              virt, op, reason, vmname, uuidstr, vm->pid);

Aargh - another instance of using the wrong type for a pid.  But that's
not your fault, and should be cleaned up all at once.

At any rate, the change makes sense, so I've pushed it, as well as
adding you to AUTHORS.  Let me know if you need any change to a
preferred spelling.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]