[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 3/4] qemu: Refactor qemuMonitorGetBlockInfo



On Wed, Jan 25, 2012 at 12:30:43 +0100, Michal Privoznik wrote:
> On 23.01.2012 14:30, Jiri Denemark wrote:
> > QEMU always sends details about all available block devices as an answer
> > for "info block"/"query-block" command. On the other hand, our
> > qemuMonitorGetBlockInfo was made for a single block devices queries
> > only. Thus, when asking for multiple devices, we asked qemu multiple
> > times to always get the same answer from which different parts were
> > filtered. This patch makes qemuMonitorGetBlockInfo return a hash table
> > of all block devices, which may later be used for getting details about
> > specific devices.
> > ---
> >  src/qemu/qemu_hotplug.c      |   22 +++++++++++--------
> >  src/qemu/qemu_monitor.c      |   43 +++++++++++++++++++++++++++++++-------
> >  src/qemu/qemu_monitor.h      |    9 +++++--
> >  src/qemu/qemu_monitor_json.c |   28 ++++++++++--------------
> >  src/qemu/qemu_monitor_json.h |    3 +-
> >  src/qemu/qemu_monitor_text.c |   47 ++++++++++++++++++++++++-----------------
> >  src/qemu/qemu_monitor_text.h |    3 +-
> >  7 files changed, 95 insertions(+), 60 deletions(-)
> > 
> 
> ACK

This patch was independent so I just pushed it.

Jirka


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]