[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v2 3/5] Introduce virDomainSuspendForDuration API



On 01/27/2012 06:34 AM, Michal Privoznik wrote:
>>> +int                     virDomainSuspendForDuration (virDomainPtr domain,
>>> +                                                     unsigned int target,
>>> +                                                     unsigned long long duration,
>>> +                                                     unsigned int flags);
>>
>> NB, I would prefer to have this called either
>>
>>   virDomainPMSuspendForDuration
>>   virDomainNodeSuspendForDuration
>>
>> Since just using ""virDomainSuspendXXX" prefix, implies it is related
>> to the existing API of that name.
> 
> Yes, but on the other hand, virDomainNode make me think it's (somehow,
> magically) related to the host :)

I also dislike virDomainNode..., but think that
virDomainPMSuspendForDuration sounds reasonable.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]