[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 1/4] xml: Add element <title> to allow short description of domains



Dňa 27.1.2012 20:03, Dave Allan  wrote / napísal(a):
On Fri, Jan 27, 2012 at 05:31:20PM +0000, Daniel P. Berrange wrote:
On Fri, Jan 27, 2012 at 06:22:16PM +0100, Peter Krempa wrote:
This patch adds a new element<title>  to the domain XML. This attribute
can hold a short title defined by the user to ease the identification of
domains. The title is limited to 40 bytes and can't contain newlines.

I'm not convinced that putting a hard limit on the title length
is a good idea. That feels like a limitation just to suit the
display used in virsh. If an app only has space to show 40
characters, then it is free to truncate and append '...'

Agreed; virsh can do what it wants with the data.

Ok, there's no problem to lift that restriction.

Peter


Also note that 40 bytes may be equivalent to as few as 12-15
printable characters in UTF-8 with non-western languages
since single characters can take 3 bytes or even more

Daniel
--
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|

--
libvir-list mailing list
libvir-list redhat com
https://www.redhat.com/mailman/listinfo/libvir-list


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]