[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] Add virStorageVolResize()



On Sat, Jan 28, 2012 at 2:27 AM, Eric Blake <eblake redhat com> wrote:
> On 01/27/2012 04:40 PM, Zeeshan Ali (Khattak) wrote:
>> From: "Zeeshan Ali (Khattak)" <zeeshanak gnome org>
>>
>> Add a new function to allow changing of capacity of storage volumes.
> Part 2 of my review - the RPC implementation.

Looks good.

>> @@ -2667,7 +2673,8 @@ enum remote_procedure {
>>      REMOTE_PROC_DOMAIN_SET_INTERFACE_PARAMETERS = 256, /* autogen autogen */
>>      REMOTE_PROC_DOMAIN_GET_INTERFACE_PARAMETERS = 257, /* skipgen skipgen */
>>      REMOTE_PROC_DOMAIN_SHUTDOWN_FLAGS = 258, /* autogen autogen */
>> -    REMOTE_PROC_STORAGE_VOL_WIPE_PATTERN = 259 /* autogen autogen */
>> +    REMOTE_PROC_STORAGE_VOL_WIPE_PATTERN = 259, /* autogen autogen */
>> +    REMOTE_PROC_STORAGE_VOL_RESIZE = 300 /* autogen autogen */
>
> Skipping is not allowed :)  260 is just fine.

What? 259 + 1 != 300? :) I guess its time I learn to count beyond 259. :)

-- 
Regards,

Zeeshan Ali (Khattak)
FSF member#5124


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]