[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 1/4] xml: Add element <title> to allow short description of domains

On 01/27/2012 10:22 AM, Peter Krempa wrote:
> This patch adds a new element <title> to the domain XML. This attribute
> can hold a short title defined by the user to ease the identification of
> domains. The title is limited to 40 bytes and can't contain newlines.
>  *include/libvirt/libvirt.h.in
>         - add macro specifying maximal note length
>  *docs/formatdomain.html.in
>  *docs/schemas/domaincommon.rng
>         - add schema grammar for the new element and documentation
>   *src/conf/domain_conf.c
>   *src/conf/domain_conf.h
>         - add field to hold the new attribute
>         - add code to parse and create XML with the new attribute
> ---
> This patch is basicaly identical with those in previous versions. I just
> added a macro to set the maximal length of the <title> element to ease
> future possible changes.

And yet length is the sticking point :)

> +++ b/tests/qemuxml2argvdata/qemuxml2argv-minimal.xml
> @@ -1,6 +1,11 @@
>  <domain type='qemu'>
>    <name>QEMUGuest1</name>
>    <uuid>c7a5fdbd-edaf-9455-926a-d65c16db1809</uuid>
> +  <description>
> +      A test of qemu&apos;s minimal configuration.
> +      This test also tests the description and title elements.
> +  </description>
> +  <title>A description of the test machine.</title>

Thanks for adding the tests.

Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]