[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v2 3/5] Introduce virDomainSuspendForDuration API



On 01/27/2012 09:12 PM, Eric Blake wrote:
> On 01/26/2012 12:59 PM, Michal Privoznik wrote:
>> This API allows a domain to be put into one of S# ACPI states.
>> Currently, S3 and S4 are supported. These states are shared
>> with virNodeSuspendForDuration.
>> However, for now we don't support any duration other than zero.
>> The same apply for flags.
> 
> I'm not reviewing 1, 2, or 4(as Dan said, there's still some churn on
> the qemu side), but I can review this one and 5 for accuracy, assuming
> you make the agreed name changes.
> 
>>  /**
>> + * virDomainSuspendForDuration:
>> + * @dom: a domain object
>> + * @target: an OR'ed set of virNodeSuspendTarget
> 
> This is _not_ an OR'd set, but a linear list.  I'd say:
> 
> @target: a value from virNodeSuspendTarget
...

I see you pushed before reading my email, so I'm pushing my proposed
cleanups under the trivial rule.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]